Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journey pattern ref parsing in timetables data inserter #214

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

Leitsi
Copy link
Contributor

@Leitsi Leitsi commented Nov 20, 2023

This change is Reviewable

Was like this for all other objects already.
Unfortunately there doesn't seem to be any "deep strict" mode in Zod,
so we have to add them individually like this.
Using star import would result in this kind of object being imported:
 {
    _vehicle_schedule_frames: [Getter],
    _journey_pattern_refs: [Getter],
    default: {
      _vehicle_schedule_frames: { ... },
      _journey_pattern_refs: { ... }
    }
  }
This is not valid when passed to the json schema parser.
Copy link
Contributor

@jarkkoka jarkkoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Leitsi)

@Leitsi Leitsi merged commit 3b602d9 into main Nov 21, 2023
11 checks passed
@Leitsi Leitsi deleted the fix-tdi-jpr-parsing branch November 21, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants